Direct mapped visited set imp - #63
Merged
Merged
Conversation
…etter memory management
TamimEhsan
marked this pull request as draft
August 19, 2026 04:36
TamimEhsan
marked this pull request as ready for review
August 19, 2026 04:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new epoch based visited set implementation and uses compile time abstraction for the visited set. The default implementation is still the HashBasedBooleanSet and the implementation stays the same exactly. So, no regression introduced.
Why the new Epoch Based Set
The hash based set due to its use of unordered set needs dynamic memory allocation and deallocation. So, that contributes to the whole QPS. For higher topk or EF this impacts the overall runtime. So, an alternative implementation is added. The choice is still hardcoded in
visited_set.hpp. That's a task for the future.Performance
Dataset: GIST10M, Topk = 10, quantization = 9 bit